[DO NOT MERGE] Fairer Queue implementation for individual queues#4692
Open
DilwoarH wants to merge 8 commits intofeat/fair-queue-skeletonfrom
Open
[DO NOT MERGE] Fairer Queue implementation for individual queues#4692DilwoarH wants to merge 8 commits intofeat/fair-queue-skeletonfrom
DilwoarH wants to merge 8 commits intofeat/fair-queue-skeletonfrom
Conversation
…s and job creation
risicle
reviewed
Dec 31, 2025
| deliver_letter.apply_async(kwargs={"notification_id": id}, queue=QueueNames.SEND_LETTER) | ||
| message_group_kwargs = {} | ||
| if (current_app.config.get("ENABLE_SQS_FAIR_GROUPING", False)): | ||
| notification = get_notification_by_id(id) |
Member
There was a problem hiding this comment.
This celery task was explicitly written so it didn't have to hit the database and this perfectly illustrates my objection to implementing group ids in this way, as mentioned here #4676 (comment) and in many other places.
Contributor
Author
ref: #4676 (comment) |
DilwoarH
commented
Dec 31, 2025
|
|
||
| message_group_kwargs = {} | ||
| if (current_app.config.get("ENABLE_SQS_FAIR_GROUPING", False)): | ||
| notification = notifications_dao.get_notification_by_id(notification_id) |
Contributor
Author
There was a problem hiding this comment.
We don't want to do this (calling the database) - this is put in as an example
DilwoarH
commented
Dec 31, 2025
| message_group_kwargs = {} | ||
|
|
||
| if (current_app.config.get("ENABLE_SQS_FAIR_GROUPING", False)): | ||
| notification = Notification.query.filter(Notification.id == notification_id).one() |
Contributor
Author
There was a problem hiding this comment.
We don't want to do this (calling the database) - this is put in as an example
DilwoarH
commented
Dec 31, 2025
| queue_name = QueueNames.LETTERS | ||
| message_group_kwargs = {} | ||
| if (current_app.config.get("ENABLE_SQS_FAIR_GROUPING", False)): | ||
| notification = Notification.query.filter(Notification.id == notification_id).one() |
Contributor
Author
There was a problem hiding this comment.
We don't want to do this (calling the database) - this is put in as an example
DilwoarH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements fairer queue message grouping for individual queues
Queues implemented
Why
This is needed to complete the fairer queue work done in #4676